Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ] - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ]
Date
Msg-id CAA4eK1KYSY+Rby+mYhuv7XoYr02NQ3g3MjCWf1BWKBjYgyTa3Q@mail.gmail.com
Whole thread Raw
In response to Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ]  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ]
List pgsql-hackers
On Wed, Jan 21, 2015 at 8:51 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> I didn't understand the coding in GetQueryResult(); why do we check the
> result status of the last returned result only?  It seems simpler to me
> to check it inside the loop, but maybe there's a reason you didn't do it
> like that?
>
> Also, what is the reason we were ignoring those errors only in
> "completedb" mode?  It doesn't seem like it would cause any harm if we
> did it in all cases.  That means we can just not have the "completeDb"
> flag at all.
>

IIRC it is done to match the existing behaviour where such errors are
ignored we use this utility to vacuum database.


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Merging postgresql.conf and postgresql.auto.conf
Next
From: Alvaro Herrera
Date:
Subject: Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ]