Amit Kapila wrote:
> On Wed, Jan 21, 2015 at 8:51 PM, Alvaro Herrera <alvherre@2ndquadrant.com>
> wrote:
> >
> > I didn't understand the coding in GetQueryResult(); why do we check the
> > result status of the last returned result only? It seems simpler to me
> > to check it inside the loop, but maybe there's a reason you didn't do it
> > like that?
> >
> > Also, what is the reason we were ignoring those errors only in
> > "completedb" mode? It doesn't seem like it would cause any harm if we
> > did it in all cases. That means we can just not have the "completeDb"
> > flag at all.
>
> IIRC it is done to match the existing behaviour where such errors are
> ignored we use this utility to vacuum database.
I think that's fine, but we should do it always, not just in
whole-database mode.
I've been hacking this patch today BTW; hope to have something to show
tomorrow.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
