Postgres Pro
Downloads
Home   >   mailing lists

Re: Hard to maintain duplication in contain_volatile_functions_not_nextval_walker - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Hard to maintain duplication in contain_volatile_functions_not_nextval_walker
Date
Msg-id CAA4eK1KNEyv55WgrktshUQOzU4JwT_aupCkTaQuP_=zYJsLoNA@mail.gmail.com
Whole thread Raw
In response to Hard to maintain duplication in contain_volatile_functions_not_nextval_walker  (Andres Freund <andres@anarazel.de>)
Responses Re: Hard to maintain duplication in contain_volatile_functions_not_nextval_walker  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view
On Sat, May 28, 2016 at 12:28 AM, Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> contain_volatile_functions_walker is duplicated, near entirely, in
> contain_volatile_functions_not_nextval_walker.
>

Previously, I also had same observation.

> Wouldn't it have been better not to duplicate, and keep a flag about
> ignoring nextval in the context variable?
>

makes sense.  +1 for doing it in the way as you are suggesting.


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [GENERAL] Permission Denied Error on pg_xlog/RECOVERYXLOG file
Next
From: Amit Kapila
Date:
Subject: Re: Parallel pg_dump's error reporting doesn't work worth squat