Re: Small documentation improvement for ALTER SUBSCRIPTION - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Small documentation improvement for ALTER SUBSCRIPTION
Date
Msg-id CAA4eK1K1WM0pmF+sJbnqVt787c69mZuUfUcmjRk__iRkTp+WqA@mail.gmail.com
Whole thread Raw
In response to Re: Small documentation improvement for ALTER SUBSCRIPTION  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Small documentation improvement for ALTER SUBSCRIPTION
List pgsql-hackers
On Tue, Aug 10, 2021 at 6:31 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Mon, Aug 9, 2021 at 1:01 PM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> But "REFRESH PUBLICATION refresh_option" seems wrong in terms of SQL
> syntax, not?
>
> Given there could be multiple options how about using
> "<replaceable>refresh_options</replaceable>"? That is, the sentence
> will be:
>
> Additionally, <replaceable>refresh_options</replaceable> as described
> under <literal>REFRESH PUBLICATION</literal> may be specified,
> except in the case of <literal>DROP PUBLICATION</literal>.
>

Normally (at least on this doc page), we use this tag for some defined
option, syntax and as refresh_options is none of them, it would look a
bit awkward.

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION
Next
From: Amit Kapila
Date:
Subject: Re: [bug] Logical Decoding of relation rewrite with toast does not reset toast_hash