Re: elog(DEBUG2 in SpinLocked section. - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: elog(DEBUG2 in SpinLocked section.
Date
Msg-id CAA4eK1Jx6K_YidBoP+3Y6YJYCbULM=eDpN6v5KYTAxFd9oqYGQ@mail.gmail.com
Whole thread Raw
In response to Re: elog(DEBUG2 in SpinLocked section.  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: elog(DEBUG2 in SpinLocked section.  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers
On Tue, Jun 2, 2020 at 2:05 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>
> On 2020/06/02 16:15, Kyotaro Horiguchi wrote:
> > Hello.
> >
> > I noticed that UpdateSpillStats calls "elog(DEBUG2" within
> > SpinLockAcquire section on MyWalSnd.  The lock doesn't protect rb and
> > in the first place the rb cannot be modified during the function is
> > running.
> >
> > It should be out of the lock section.

Right.

>
> Thanks for the patch! It looks good to me.
>

The patch looks good to me as well.  I will push this unless Fujii-San
wants to do it.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: elog(DEBUG2 in SpinLocked section.
Next
From: Peter Eisentraut
Date:
Subject: Re: OpenSSL 3.0.0 compatibility