Postgres Pro
Downloads
Home   >   mailing lists

Re: elog(DEBUG2 in SpinLocked section. - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: elog(DEBUG2 in SpinLocked section.
Date
Msg-id 959a8e3a-ad6b-bdd8-bbd0-cede464f05e9@oss.nttdata.com
Whole thread Raw
In response to elog(DEBUG2 in SpinLocked section.  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: elog(DEBUG2 in SpinLocked section.  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 

On 2020/06/02 16:15, Kyotaro Horiguchi wrote:
> Hello.
> 
> I noticed that UpdateSpillStats calls "elog(DEBUG2" within
> SpinLockAcquire section on MyWalSnd.  The lock doesn't protect rb and
> in the first place the rb cannot be modified during the function is
> running.
> 
> It should be out of the lock section.

Thanks for the patch! It looks good to me.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Resetting spilled txn statistics in pg_stat_replication
Next
From: Amit Kapila
Date:
Subject: Re: elog(DEBUG2 in SpinLocked section.