Re: Perform streaming logical transactions by background workers and parallel apply - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Perform streaming logical transactions by background workers and parallel apply
Date
Msg-id CAA4eK1JnAjWOm6HSTrvqui8JCDhuNguyfdQ73WPnXXh6nH=MaA@mail.gmail.com
Whole thread Raw
In response to RE: Perform streaming logical transactions by background workers and parallel apply  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
List pgsql-hackers
On Fri, Dec 2, 2022 at 4:57 PM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> handle_streamed_transaction()
>
> ```
> +                       if (apply_action == TRANS_LEADER_SEND_TO_PARALLEL)
> +                               pa_send_data(winfo, s->len, s->data);
> +                       else
> +                               stream_write_change(action, &original_msg);
> ```
>
> Comments are needed here, 0001 has that bu removed in 0002.
> There are some similar lines.
>

I have suggested removing it because they were just saying what is
evident from the code and doesn't seem to be adding any value. I would
say they were rather confusing.

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Fix gin index cost estimation
Next
From: Daniel Gustafsson
Date:
Subject: Re: pg_upgrade: Make testing different transfer modes easier