Re: PGdoc: add missing ID attribute to create_subscription.sgml - Mailing list pgsql-hackers

On Tue, Mar 28, 2023 at 9:49 AM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Thank you for prompt reply!
>
> > Hmm, my above-suggested wording was “publish_via_partition_root
> > parameter “ but it seems you (accidentally?) omitted the word
> > “parameter”.
>
> It is my carelessness, sorry for inconvenience. PSA new ones.
>

In 0001, patch, I see a lot of long lines like below:
-   subscription can be used with the
<literal>disable_on_error</literal> option.
-   Then, you can use
<function>pg_replication_origin_advance()</function> function
-   with the <parameter>node_name</parameter> (i.e.,
<literal>pg_16395</literal>)
+   subscription can be used with the <link
linkend="sql-createsubscription-with-disable-on-error"><literal>disable_on_error</literal></link>

Isn't it better to move the link-related part to the next line
wherever possible? Currently, it looks bit odd.

Why 0002 patch is part of this thread? I thought here we want to add
'ids' to entries corresponding to Create Subscription as we have added
the one in commit ecb696.

--
With Regards,
Amit Kapila.