On Fri, Jan 29, 2016 at 6:55 PM, Alexander Korotkov <a.korotkov@postgrespro.ru> wrote:Also couple of minor comments from me.I think this+ StrNCpy(LWLockTrancheRequestArray[LWLockTrancheRequestsCount].tranche_name, tranche_name, strlen(tranche_name) + 1);should be + StrNCpy(LWLockTrancheRequestArray[LWLockTrancheRequestsCount].tranche_name, tranche_name, sizeof(LWLockTrancheRequestArray[LWLockTrancheRequestsCount].tranche_name));I think you are right, otherwise it might try to copy more, howaboutStrNCpy(LWLockTrancheRequestArray[LWLockTrancheRequestsCount].tranche_name, tranche_name, Min (strlen(tranche_name) + 1, sizeof(LWLockTrancheRequestArray[LWLockTrancheRequestsCount].tranche_name)));
Also couple of minor comments from me.I think this+ StrNCpy(LWLockTrancheRequestArray[LWLockTrancheRequestsCount].tranche_name, tranche_name, strlen(tranche_name) + 1);should be + StrNCpy(LWLockTrancheRequestArray[LWLockTrancheRequestsCount].tranche_name, tranche_name, sizeof(LWLockTrancheRequestArray[LWLockTrancheRequestsCount].tranche_name));
+ StrNCpy(LWLockTrancheRequestArray[LWLockTrancheRequestsCount].tranche_name, tranche_name, strlen(tranche_name) + 1);
+ StrNCpy(LWLockTrancheRequestArray[LWLockTrancheRequestsCount].tranche_name, tranche_name, sizeof(LWLockTrancheRequestArray[LWLockTrancheRequestsCount].tranche_name));
And as far as I know english "it's" should be "its" in the sentence below.+ from <function>_PG_init</>. Tranche repersents an array of LWLocks and+ can be accessed by it's name. First parameter <literal>tranche_name</>Right, will change.
And as far as I know english "it's" should be "its" in the sentence below.+ from <function>_PG_init</>. Tranche repersents an array of LWLocks and+ can be accessed by it's name. First parameter <literal>tranche_name</>
+ from <function>_PG_init</>. Tranche repersents an array of LWLocks and+ can be accessed by it's name. First parameter <literal>tranche_name</>
pgsql-hackers by date:
Соглашаюсь с условиями обработки персональных данных
