Re: Questions/Observations related to Gist vacuum - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Questions/Observations related to Gist vacuum
Date
Msg-id CAA4eK1J7Bp+tLZc6eRry0VmG6xVannbxBcHKubwyuMhe0AVotg@mail.gmail.com
Whole thread Raw
In response to Re: Questions/Observations related to Gist vacuum  (Dilip Kumar <dilipbalaut@gmail.com>)
Responses Re: Questions/Observations related to Gist vacuum
List pgsql-hackers
On Fri, Oct 18, 2019 at 9:41 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Wed, Oct 16, 2019 at 7:22 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> >
> > On 16 October 2019 12:57:03 CEST, Amit Kapila <amit.kapila16@gmail.com> wrote:
> > >On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas <hlinnaka@iki.fi>
> > >wrote:
> > >> All things
> > >> considered, I'm not sure which is better.
> > >
> > >Yeah, this is a tough call to make, but if we can allow it to delete
> > >the pages in bulkdelete conditionally for parallel vacuum workers,
> > >then it would be better.
> >
> > Yeah, if it's needed for parallel vacuum, maybe that tips the scale.
>
> Are we planning to do this only if it is called from parallel vacuum
> workers or in general?
>

I think we can do it in general as adding some check for parallel
vacuum there will look bit hackish.  It is not clear if we get enough
benefit by keeping it for cleanup phase of the index as discussed in
emails above.  Heikki, others, let us know if you don't agree here.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Questions/Observations related to Gist vacuum
Next
From: Michael Paquier
Date:
Subject: Re: Non working timeout detection in logical worker