Re: Is this a problem in GenericXLogFinish()? - Mailing list pgsql-hackers

On Sat, Oct 28, 2023 at 4:30 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Sat, Oct 28, 2023 at 03:45:13PM +0530, Amit Kapila wrote:
> > Yes, we need it to exclude any concurrent in-progress scans that could
> > return incorrect tuples during bucket squeeze operation.
>
> Thanks.  So I assume that we should just set REGBUF_NO_CHANGE when the
> primary and write buffers are the same and there are no tuples to
> move.  Say with something like the attached?
>

What if the primary and write buffer are not the same but ntups is
zero? Won't we hit the assertion again in that case?

--
With Regards,
Amit Kapila.