Re: Ordering of header file inclusion - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Ordering of header file inclusion
Date
Msg-id CAA4eK1+X9bxv32q2j_it8GzLbFQbYdVre+LH=N7+=9Cn1F=taQ@mail.gmail.com
Whole thread Raw
In response to Re: Ordering of header file inclusion  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Nov 22, 2019 at 8:07 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> vignesh C <vignesh21@gmail.com> writes:
> > After the inclusion they have define and further include based on #if
> > defined. In few cases I had seen the include happens at the end of the
> > file like in regcomp.c as there may be impact. I felt it is better not
> > to change these files. Let me know your thoughts on the same.
>
> I think the point of this patch series is just to make cosmetic
> adjustments in places where people have randomly failed to maintain
> alphabetic order of a consecutive group of #include's.  Messing with
> examples like the above is way out of scope, if you ask me --- it
> entails more analysis, and more risk of breakage, than a purely
> cosmetic goal is worth.
>

+1.  I agree with what Tom said, so let's leave such things as it is.


-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: RE: [BUG] (firsttupleslot)==NULL is redundant or is possible nulldereference?
Next
From: Tels
Date:
Subject: Re: backup manifests