Re: TerminateOtherDBBackends code comments inconsistency. - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: TerminateOtherDBBackends code comments inconsistency.
Date
Msg-id CAA4eK1+0yPCUukrLNo=xpf=2gpgZBjDe8KxoVCT1Gq2Vv1o0xQ@mail.gmail.com
Whole thread Raw
In response to Re: TerminateOtherDBBackends code comments inconsistency.  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
On Tue, Apr 30, 2024 at 10:36 PM Noah Misch <noah@leadboat.com> wrote:
>
> >
> > >  One could argue the function should also check
> > > isBackgroundWorker and ignore even bgworkers that set proc->roleId, but I've
> > > not done that.
> >
> > What is the argument for ignoring such workers?
>
> One of the proposed code comments says, "For bgworker authors, it's convenient
> to be able to recommend FORCE if a worker is blocking DROP DATABASE
> unexpectedly."  That argument is debatable, but I do think it applies equally
> to bgworkers whether or not they set proc->roleId.
>

Agreed.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Alexander Lakhin
Date:
Subject: Test equivclass interferes with tests tsearch and advisory_lock
Next
From: Peter Eisentraut
Date:
Subject: Re: wrong comment in libpq.h