Re: Key management with tests - Mailing list pgsql-hackers

From Neil Chen
Subject Re: Key management with tests
Date
Msg-id CAA3qoJmUqgTDkBTDm0iK3DVMcy_6Ou30UPHad+-sC1UunBxXvw@mail.gmail.com
Whole thread Raw
In response to Re: Key management with tests  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Key management with tests  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Hi Bruce,

I went through these patches and executed the test script you added for the KMS section, which looks all good. 

This is a point that looks like a bug - in patch 10, you changed the location and use of *RelFileNodeSkippingWAL()*, but the modified code logic seems different from the original when encryption is not enabled. After applying this patch, it still will execute the set LSN code flow when RelFileNodeSkippingWAL returns true, and encryption not enabled.



On Thu, Apr 1, 2021 at 2:47 PM Bruce Momjian <bruce@momjian.us> wrote:
On Thu, Mar 11, 2021 at 10:31:28PM -0500, Bruce Momjian wrote:
> I have made significant progress on the cluster file encryption feature so
> it is time for me to post a new set of patches.

Here is a rebase, to keep the cfbot green.

--
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.



--
There is no royal road to learning.
HighGo Software Co.

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Asynchronous Append on postgres_fdw nodes.
Next
From: Laurenz Albe
Date:
Subject: Re: Confusing behavior of psql's \e