Re: Command Triggers, patch v11 - Mailing list pgsql-hackers

From Thom Brown
Subject Re: Command Triggers, patch v11
Date
Msg-id CAA-aLv43Ka8P0oF5-+L3qkHnd6cFgMPNL+Z4ag-Va2+T6QiDEQ@mail.gmail.com
Whole thread Raw
In response to Re: Command Triggers, patch v11  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 28 February 2012 15:03, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Thom Brown <thom@linux.com> writes:
>> Well the problem is that you can add commands to a trigger en masse,
>> but you can only remove them one at a time.  Couldn't we at least
>> allow the removal of multiple commands at the same time?  The docs you
>> wrote suggest you can do this, but you can't.
>
> This seems over-complicated.  Triggers on tables do not have alterable
> properties, why should command triggers?  I vote for
>
>        CREATE COMMAND TRIGGER name ... properties ...;
>
>        DROP COMMAND TRIGGER name;
>
> full stop.  If you want to run the same trigger function on some more
> commands, add another trigger name.

This would make more sense, particularly since dropping a command
trigger, as it stands, doesn't necessarily drop the trigger.

--
Thom


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: FDW system columns
Next
From: Robert Haas
Date:
Subject: Re: pgsql_fdw, FDW for PostgreSQL server