Re: [PATCH] Fix crash when disabling auto commit - Mailing list pgadmin-hackers

From Sanket Mehta
Subject Re: [PATCH] Fix crash when disabling auto commit
Date
Msg-id CA+yw=mMH0fTn13RAmCRQSBx4Evv1L5sd5_HTTy7hqCmvYk3WdA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Fix crash when disabling auto commit  (Sanket Mehta <sanket.mehta@enterprisedb.com>)
Responses Re: [PATCH] Fix crash when disabling auto commit
List pgadmin-hackers
Hi John,

I have tried to reproduce the scenario but not able to reproduce the crash in my system.
can you please provide your steps which causes crash on your machine?

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, Jun 12, 2015 at 11:50 AM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

I am looking into the same and few other issues in code and will send the patch soon.


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, Jun 12, 2015 at 1:49 AM, John Obaterspok <john.obaterspok@gmail.com> wrote:
Fix crash when string has only alphas (like 'rollback')

diff --git a/pgadmin/frm/frmQuery.cpp b/pgadmin/frm/frmQuery.cpp
index b5a2f56..110bbc7 100644
--- a/pgadmin/frm/frmQuery.cpp
+++ b/pgadmin/frm/frmQuery.cpp
@@ -2522,7 +2522,7 @@ bool frmQuery::isBeginNotRequired(wxString query)
  /*
  * Check word length (since "beginx" is not "begin").
  */
- while(wxIsalpha(query.GetChar(wordlen)))
+ while(wordlen < query.Length() && wxIsalpha(query.GetChar(wordlen)))
  wordlen++;
 
  /*


pgadmin-hackers by date:

Previous
From: Sanket Mehta
Date:
Subject: Re: [PATCH] Fix crash when disabling auto commit
Next
From: Jacek Wielemborek
Date:
Subject: SSH error messages not shown