Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Fix crash when disabling auto commit - Mailing list pgadmin-hackers

From Sanket Mehta
Subject Re: [PATCH] Fix crash when disabling auto commit
Date
Msg-id CA+yw=mNK+hy2rCA0-X3S37pXejt_srt1i7_zNhNKMMC0xF6npA@mail.gmail.com
Whole thread Raw
In response to [PATCH] Fix crash when disabling auto commit  (John Obaterspok <john.obaterspok@gmail.com>)
Responses Re: [PATCH] Fix crash when disabling auto commit
List pgadmin-hackers
Tree view
Hi,

I am looking into the same and few other issues in code and will send the patch soon.


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, Jun 12, 2015 at 1:49 AM, John Obaterspok <john.obaterspok@gmail.com> wrote:
Fix crash when string has only alphas (like 'rollback')

diff --git a/pgadmin/frm/frmQuery.cpp b/pgadmin/frm/frmQuery.cpp
index b5a2f56..110bbc7 100644
--- a/pgadmin/frm/frmQuery.cpp
+++ b/pgadmin/frm/frmQuery.cpp
@@ -2522,7 +2522,7 @@ bool frmQuery::isBeginNotRequired(wxString query)
  /*
  * Check word length (since "beginx" is not "begin").
  */
- while(wxIsalpha(query.GetChar(wordlen)))
+ while(wordlen < query.Length() && wxIsalpha(query.GetChar(wordlen)))
  wordlen++;
 
  /*

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: [PATCH] Add ElapsedTimeToString to format execution time in a more readable manner (instead of showing everything as msec)
Next
From: Sanket Mehta
Date:
Subject: Re: [PATCH] Fix crash when disabling auto commit