Re: pgsql: Refactor all TAP test suites doing connection checks - Mailing list pgsql-committers

From Thomas Munro
Subject Re: pgsql: Refactor all TAP test suites doing connection checks
Date
Msg-id CA+hUKGLvexxLBAB_Mb=Eqr6iERW-z74pMVAgKinJ_HK0ZK4O7g@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Refactor all TAP test suites doing connection checks  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Refactor all TAP test suites doing connection checks
List pgsql-committers
On Tue, Apr 6, 2021 at 12:15 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Michael Paquier <michael@paquier.xyz> writes:
> > On Mon, Apr 05, 2021 at 07:23:43PM -0400, Tom Lane wrote:
> >> What does seem to fix it reliably is the attached.
>
> > Thanks for confirming.  I am still surprised that this has not popped
> > up as an issue until now.  Could that be because those animals have
> > never run the LDAP, SSL or kerberos test suites over the years?
>
> Dunno.  Certainly most animals that enable TAP at all should be
> running the "authentication" test, but those others all need to
> be manually enabled, I believe.  My own animals run the SSL test
> but not LDAP or kerberos.
>
> I'm fairly sure that we've previously fixed this exact same issue
> in some tests that expected a connection failure ...

Commit f44b9b62 springs to mind.



pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks