Re: pgsql: Refactor all TAP test suites doing connection checks - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Refactor all TAP test suites doing connection checks
Date
Msg-id 936576.1617669613@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Refactor all TAP test suites doing connection checks  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Refactor all TAP test suites doing connection checks  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Apr 05, 2021 at 08:15:31PM -0400, Tom Lane wrote:
>> Dunno.  Certainly most animals that enable TAP at all should be
>> running the "authentication" test, but those others all need to
>> be manually enabled, I believe.  My own animals run the SSL test
>> but not LDAP or kerberos.

> The SSL tests have always sent down a query even for scenarios where
> the connection would fail, but they have used command_fails_like()
> rather than PostgresNode::psql.  The puzzle does not seem complete.

Well, since it's a race condition it's obviously going to be sensitive to
machine speed.  I think that Perl version, or more likely version of
IPC::Run or a related module, may enter into it too.  prairiedog has
gotten through the tests several times since yesterday without failing,
yet it's significantly slower than the other PPC Mac I was able to
consistently reproduce the problem on.  I don't think those two have
the same vintage of Perl installation, though, so Perl version seems
like a likely explanation.

            regards, tom lane



pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Next
From: Michael Paquier
Date:
Subject: pgsql: Change PostgresNode::connect_fails() to never send down queries