Re: First-draft release notes for back branches are up - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: First-draft release notes for back branches are up
Date
Msg-id CA+hUKGLsNqm=axs-mmzym9bbXMo=CV-F0_7f68jQYXb67kaBSQ@mail.gmail.com
Whole thread Raw
In response to Re: First-draft release notes for back branches are up  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: First-draft release notes for back branches are up  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, May 4, 2019 at 1:29 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Thomas Munro <thomas.munro@gmail.com> writes:
> > On Sat, May 4, 2019 at 10:29 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > +      Tolerate <literal>EINVAL</literal> and <literal>ENOSYS</literal>
> > +      error results, where appropriate, for fsync calls (Thomas Munro,
> > +      James Sewell)
>
> > Nit-picking: ENOSYS is for sync_file_range, EINVAL is for fsync.
>
> Yeah, I didn't really think it was worth distinguishing.  If there
> is some more general term that covers both calls, maybe we should
> use that?

I would just do s/fsync/fsync and sync_file_range/.  And I guess also
wrap them in <function>?

-- 
Thomas Munro
https://enterprisedb.com



pgsql-hackers by date:

Previous
From: Euler Taveira
Date:
Subject: Re: improving wraparound behavior
Next
From: Noah Misch
Date:
Subject: Re: compiler warning in pgcrypto imath.c