Re: Refactoring the checkpointer's fsync request queue - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Refactoring the checkpointer's fsync request queue
Date
Msg-id CA+hUKGL+YLUOA0eYiBXBfwW+bH5kFgh94=gQH0jHEJ-t5Y91wQ@mail.gmail.com
Whole thread Raw
In response to Re: Refactoring the checkpointer's fsync request queue  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
On Thu, Apr 4, 2019 at 11:47 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> Pushed.  Thanks for all the work on this!

I managed to break this today while testing with RELSEG_SIZE set to 1
block (= squillions of 8kb files).  The problem is incorrect arguments
to _mdfd_getseg(), in code added recently by me.  Without the
EXTENSION_DONT_CHECK_SIZE flag, it refuses to open segments following
segments that have been truncated, leading to a checkpointer fsync
panic.  It's also passing segnum where a blocknum is wanted.  It
should have used exactly the same arguments as in the old code, but
didn't.  I will push a fix shortly.

-- 
Thomas Munro
https://enterprisedb.com



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: speeding up planning with partitions
Next
From: Amit Langote
Date:
Subject: Re: speeding up planning with partitions