Re: pgsql: Add 'basebackup_to_shell' contrib module. - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date
Msg-id CA+hUKGK_J2XmrhVToBfnhnAaQVP0r5C1b6ae5Kc15cSQNMgdWw@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add 'basebackup_to_shell' contrib module.  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pgsql: Add 'basebackup_to_shell' contrib module.
List pgsql-hackers
On Wed, Mar 30, 2022 at 3:08 AM Robert Haas <robertmhaas@gmail.com> wrote:
> On Fri, Mar 25, 2022 at 5:52 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> > On Sat, Mar 26, 2022 at 9:55 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> > This line doesn't look too healthy:
> >
> > pg_basebackup: error: backup failed: ERROR:  shell command "type con >
> > "C:cirruscontrib asebackup_to_shell mp_check mp_test_tch3\base.tar""
> > failed
> >
> > I guess it's an escaping problem around \ characters.
>
> Oh, right. I didn't copy the usual incantation as completely as I
> should have done.
>
> Here's a new version, hopefully rectifying that deficiency. I also add
> a second patch here, documenting basebackup_to_shell.required_role,
> because Joe Conway observed elsewhere that I forgot to do that.

Here are your patches again, plus that kludge to make the CI run your
TAP test on Windows.

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Next
From: David Rowley
Date:
Subject: Re: Add parameter jit_warn_above_fraction