Re: pgsql: Add 'basebackup_to_shell' contrib module. - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date
Msg-id CA+Tgmoat+zbzzZQJ7poXyUwiqxQxTaUid=auB4FejZ15VvDh4Q@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add 'basebackup_to_shell' contrib module.  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: pgsql: Add 'basebackup_to_shell' contrib module.  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
On Fri, Mar 25, 2022 at 5:52 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> On Sat, Mar 26, 2022 at 9:55 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> >
https://api.cirrus-ci.com/v1/artifact/task/5637156969381888/log/contrib/basebackup_to_shell/tmp_check/log/regress_log_001_basic
>
> This line doesn't look too healthy:
>
> pg_basebackup: error: backup failed: ERROR:  shell command "type con >
> "C:cirruscontrib asebackup_to_shell mp_check mp_test_tch3\base.tar""
> failed
>
> I guess it's an escaping problem around \ characters.

Oh, right. I didn't copy the usual incantation as completely as I
should have done.

Here's a new version, hopefully rectifying that deficiency. I also add
a second patch here, documenting basebackup_to_shell.required_role,
because Joe Conway observed elsewhere that I forgot to do that.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: James Coleman
Date:
Subject: Correct docs re: rewriting indexes when table rewrite is skipped
Next
From: James Coleman
Date:
Subject: Restructure ALTER TABLE notes to clarify table rewrites and verification scans