Postgres Pro
Downloads
Home   >   mailing lists

Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes) - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)
Date
Msg-id CA+hUKGKJieGQjeHVsJ2RGJJd6WXMVMgmNFLbj8ROo=8DJLXKhg@mail.gmail.com
Whole thread Raw
In response to Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)
List pgsql-hackers
Tree view 
On Tue, Jan 7, 2025 at 9:54 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> On Tue, Jan 7, 2025 at 5:23 AM Andrew Dunstan <andrew@dunslane.net> wrote:
> > Do you have a plan for moving ahead with this?
>
> I think that all looks good, and I'll go ahead and commit it in the
> next day or two.  Sorry for the delay.

I changed some remaining off_t, because I don't want to worry about
which ones can and can't overflow.  Might as we'll get 'em all.  I
also noticed a warning due to the new lseek() macro, which just
required adding it to plperl_system.h.

And pushed.

pgsql-hackers by date:

Previous
From: Sami Imseih
Date:
Subject: Re: Sample rate added to pg_stat_statements
Next
From: jian he
Date:
Subject: Re: Eager aggregation, take 3