Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes) - Mailing list pgsql-hackers

From Jakub Wartak
Subject Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)
Date
Msg-id CAKZiRmysRBFF4maSQeAknG2LqrX69k86w3AJ_QbPF9Q=++fTgw@mail.gmail.com
Whole thread Raw
In response to Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
On Thu, Jan 9, 2025 at 4:12 AM Thomas Munro <thomas.munro@gmail.com> wrote:
>
> On Tue, Jan 7, 2025 at 9:54 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> > On Tue, Jan 7, 2025 at 5:23 AM Andrew Dunstan <andrew@dunslane.net> wrote:
> > > Do you have a plan for moving ahead with this?
> >
> > I think that all looks good, and I'll go ahead and commit it in the
> > next day or two.  Sorry for the delay.
>
> I changed some remaining off_t, because I don't want to worry about
> which ones can and can't overflow.  Might as we'll get 'em all.  I
> also noticed a warning due to the new lseek() macro, which just
> required adding it to plperl_system.h.
>
> And pushed.

Thank you very much, Thomas! (and best wishes in 2025)

-J.



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Eager aggregation, take 3
Next
From: Ashutosh Bapat
Date:
Subject: Re: Small refactoring around vacuum_open_relation