Re: Assert in heapgettup_pagemode() fails due to underlying buffer change - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Assert in heapgettup_pagemode() fails due to underlying buffer change
Date
Msg-id CA+hUKGKBuYg8iH6U4VP8vD_9fCEVhxPdqjt6Vp5_sNeBB9YrgQ@mail.gmail.com
Whole thread Raw
In response to Re: Assert in heapgettup_pagemode() fails due to underlying buffer change  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
I adjusted the code a bit more to look like the 16 coding including
restoring some very useful comments that had been lost, and pushed.

Thanks very much to Alexander and Noah for (independently) chasing
this down and reporting, testing etc, and Alvaro and Robert for review
comments.

(Passing thought: it's a bit weird that we need to zero pages at all
before restoring FPIs or initialising them.  Perhaps there is some way
to defer marking the buffer valid until after the caller gets a chance
to initialise?  Or something like that...)



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: CheckMyDatabase some error messages in two lines.
Next
From: Nathan Bossart
Date:
Subject: Re: Remove dependence on integer wrapping