Re: pg_upgrade test failure - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: pg_upgrade test failure
Date
Msg-id CA+hUKG+e788-7YMxFEdScS+V_rVYoM6-H+mTS6caoo8oJBzf=A@mail.gmail.com
Whole thread Raw
In response to Re: pg_upgrade test failure  (Andres Freund <andres@anarazel.de>)
Responses Re: pg_upgrade test failure
List pgsql-hackers
On Wed, Feb 1, 2023 at 10:04 AM Andres Freund <andres@anarazel.de> wrote:
> On January 31, 2023 12:54:42 PM PST, Thomas Munro <thomas.munro@gmail.com> wrote:
> >I'm not sure about anything, but if that's what's happening here, then
> >maybe the attached would help.  In short, it would make the previous
> >theory true (the idea of a second unlink() saving the day).
>
> Maybe we should just handle it by sleeping and retrying, if on windows? Sad to even propose...

Yeah, that's what that code I posted would do automatically, though
it's a bit hidden.  The second attempt to unlink() would see delete
already pending, and activate its secret internal sleep/retry loop.



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pg_upgrade test failure
Next
From: Thomas Munro
Date:
Subject: Re: pg_upgrade test failure