Re: Remove page-read callback from XLogReaderState. - Mailing list pgsql-hackers

On Wed, Apr 7, 2021 at 8:50 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
> I haven't changed the name "XLog reader" to "XLog decoder". I'm doing
> that but it affects somewhat wide range of code.

Thanks for the new patch set!  Let's not worry about renaming it for now.

This fails in check-world as seen on cfbot; I am not 100% sure but
this change fixes it:

@@ -1231,7 +1231,7 @@ XLogFindNextRecord(XLogFindNextRecordState *state)
                {
                        /* Rewind the reader to the beginning of the
last record. */
                        state->currRecPtr = state->reader_state->ReadRecPtr;
-                       XLogBeginRead(state->reader_state, found);
+                       XLogBeginRead(state->reader_state, state->currRecPtr);

The variable "found" seem to be useless.

I still see the 3 warnings mentioned earlier when compiling without
--enable-cassert.

There is a stray elog(HOGE) :-)