On Thu, Apr 21, 2022 at 3:55 AM Robert Haas <robertmhaas@gmail.com> wrote:
> On Tue, Apr 19, 2022 at 10:20 PM Mark Dilger
> <mark.dilger@enterprisedb.com> wrote:
> > Looks like most people voted for (B). In support of that option, here are patches for master and REL_14_STABLE.
Notethat I extended the tests compared to v9, which found a problem that is fixed for v10:
>
> OK, I committed these. I am not totally sure we've got all the
> problems sorted here, but I don't think that continuing to not commit
> anything is going to be better, so here we go.
Looks like this somehow broke on a Windows box:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2022-04-20%2016%3A34%3A19
[14:05:49.729](0.001s) not ok 16 - pg_dumpall: option
--exclude-database rejects multipart pattern ".*": matches
[14:05:49.730](0.000s)
[14:05:49.730](0.000s) # Failed test 'pg_dumpall: option
--exclude-database rejects multipart pattern ".*": matches'
# at t/002_pg_dump.pl line 3985.
[14:05:49.730](0.000s) # 'pg_dumpall: error:
improper qualified name (too many dotted names): .gitignore
# '
# doesn't match '(?^:pg_dumpall: error: improper qualified name
\\(too many dotted names\\): \\.\\*)'
