Hi Khushboo,
Matt and I took a look at your patch and noticed that there is code duplication between the lines you added and the preceding block of code.
Instead of repeating the code in the else block, why not just remove the if condition?
Also, the BigNumber casting in the previous block seems unnecessary since there is no arithmetic, only comparisons happening.
It may help to add some jasmine tests around the makeComparator method.
Tira & Matt
