Re: Review: Extra Daemons / bgworker - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Review: Extra Daemons / bgworker
Date
Msg-id CA+U5nM+V1WygfmAn7fyRNhQu9RdUgH7188DNWROGy0dvK=C+uA@mail.gmail.com
Whole thread Raw
In response to Re: Review: Extra Daemons / bgworker  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Review: Extra Daemons / bgworker  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On 5 December 2012 15:09, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Here's a first attempt at a new documentation chapter.  This goes in
> part "Server Programming", just after the SPI chapter.
>
> I just noticed that worker_spi could use some more sample code, for
> example auth_counter was getting its own LWLock and also its own shmem
> area, which would be helpful to demonstrate I think.

"to run once" -> "to run when"

Prefer
BgWorkerStart_ConsistentState to be renamed to BgWorkerRun_InHotStandby
BgWorkerStart_RecoveryFinished to be renamed to BgWorkerRun_InNormalMode

presumably a process will shutdown if (BgWorkerRun_InHotStandby &&
!BgWorkerRun_InNormalMode)


-- Simon Riggs                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Review: Extra Daemons / bgworker
Next
From: Andres Freund
Date:
Subject: Re: Dumping an Extension's Script