Re: patch: improve SLRU replacement algorithm - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: patch: improve SLRU replacement algorithm
Date
Msg-id CA+U5nM+V1JbYUL2eBmL1q731fSPUWxJ0zj-d85=G=qg-FmhNaA@mail.gmail.com
Whole thread Raw
In response to Re: patch: improve SLRU replacement algorithm  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Apr 5, 2012 at 1:23 AM, Robert Haas <robertmhaas@gmail.com> wrote:

> I don't think we're micro-optimizing, either.  I don't consider
> avoiding a 10-second cessation of all database activity to be a
> micro-optimization even on a somewhat artificial benchmark.

Robert is not skewing the SLRU mechanism towards this case, he is
simply fixing something so gross that "bug" is the only word for it,
and that shows up clearly on this test. I'm happy that the fix
proposed has general utility without negative impact on other
workloads.

In general terms, I agree we shouldn't rely on pgbench as a general
workload, nor should we solely tune Postgres for throughput without
regard to response time. But that point is not relevant to this
specific issue.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-hackers by date:

Previous
From: Yeb Havinga
Date:
Subject: Re: bugfix for cursor arguments in named notation
Next
From: Simon Riggs
Date:
Subject: Re: patch: improve SLRU replacement algorithm