Re: Incorrect comment in be-secure-openssl.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Incorrect comment in be-secure-openssl.c
Date
Msg-id CA+Tgmobzy8s0ZvoNeZ5Nw4dVJa-L_gNO7-vduHExXCvBPntBLQ@mail.gmail.com
Whole thread Raw
In response to Re: Incorrect comment in be-secure-openssl.c  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Incorrect comment in be-secure-openssl.c
List pgsql-hackers
On Sun, May 31, 2020 at 2:54 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, May 29, 2020 at 02:38:53PM +0900, Michael Paquier wrote:
> > Indeed, looks good to me.  I'll go fix, ust let's wait and see first
> > if others have any comments.
>
> Actually, I was reading again the new sentence, and did not like its
> first part.  Here is a rework that looks much better to me:
>   * Load hardcoded DH parameters.
>   *
> - * To prevent problems if the DH parameter files don't even exist, we
> - * can load hardcoded DH parameters supplied with the backend.
> + * If DH parameters cannot be loaded from a specified file, we can load
> + * the hardcoded DH parameters supplied with the backend to prevent
> + * problems.
>
> Daniel, is that fine for you?

I don't understand why that change is an improvement.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: Re: race condition when writing pg_control
Next
From: "Bossart, Nathan"
Date:
Subject: Re: Add MAIN_RELATION_CLEANUP and SECONDARY_RELATION_CLEANUP optionsto VACUUM