Re: Incorrect comment in be-secure-openssl.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Incorrect comment in be-secure-openssl.c
Date
Msg-id 20200531065415.GA2008@paquier.xyz
Whole thread Raw
In response to Re: Incorrect comment in be-secure-openssl.c  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Incorrect comment in be-secure-openssl.c  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Fri, May 29, 2020 at 02:38:53PM +0900, Michael Paquier wrote:
> Indeed, looks good to me.  I'll go fix, ust let's wait and see first
> if others have any comments.

Actually, I was reading again the new sentence, and did not like its
first part.  Here is a rework that looks much better to me:
  * Load hardcoded DH parameters.
  *
- * To prevent problems if the DH parameter files don't even exist, we
- * can load hardcoded DH parameters supplied with the backend.
+ * If DH parameters cannot be loaded from a specified file, we can load
+ * the hardcoded DH parameters supplied with the backend to prevent
+ * problems.

Daniel, is that fine for you?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: OpenSSL 3.0.0 compatibility
Next
From: Антон Пацев
Date:
Subject: Proposal: remove string "contains errors; unaffected changes were applied"