Re: Optimization for updating foreign tables in Postgres FDW - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Optimization for updating foreign tables in Postgres FDW
Date
Msg-id CA+Tgmobvg=KV6nm-doG+KT-2d+T9Jok5gxrRM4jm9VJfCFw9+A@mail.gmail.com
Whole thread Raw
In response to Re: Optimization for updating foreign tables in Postgres FDW  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: Optimization for updating foreign tables in Postgres FDW  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Tue, Apr 12, 2016 at 10:24 PM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:
>> How about we encapsulate the while (PQisBusy(...)) loop into a new
>> function pgfdw_get_result(), which can be called after first calling
>> PQsendQueryParams()?  So then this code will say dmstate->result =
>> pgfdw_get_result(dmstate->conn).  And we can do something similar for
>> the other call to PQexecParams() in create_cursor().  Then let's also
>> add something like pgfdw_exec_query() which calls PQsendQuery() and
>> then pgfdw_get_result, and use that to replace all of the existing
>> calls to PQexec().
>>
>> Then all the SQL postgres_fdw executes would be interruptible, not
>> just the new stuff.
>
> Seems like a good idea.  Will do.

When will you do this?  We are on a bit of a time budget here.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Next
From: Michael Paquier
Date:
Subject: Re: SET ROLE and reserved roles