Re: [HACKERS] Re: Poor cost estimate with interaction between tablecorrelation and partial indexes - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Re: Poor cost estimate with interaction between tablecorrelation and partial indexes
Date
Msg-id CA+Tgmobv3VPRGi1FXeVNoxBwOuuH_J_J0YuU8HwRu2WH9QMvyA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Re: Poor cost estimate with interaction between tablecorrelation and partial indexes  (Michael Malis <michaelmalis2@gmail.com>)
List pgsql-hackers
On Sun, Aug 27, 2017 at 8:31 PM, Michael Malis <michaelmalis2@gmail.com> wrote:
> (Sorry David. I initially replied only to you)
>
> Ok. I've attached a patch of a proof-of-concept. I have a few
> questions about tests.
>
> What is typical workflow to add tests for changes to the planner?

Add submitted patches at commitfest.postgresql.org

> Also
> I ran make check and it appears one of the existing tests is failing.
> What is a typical way for going about discovering why the query plan
> for a specific query changed?

I don't have any magic answer on this point.

> Also, how should I go about changing the
> old test? Should I replace the old test output with the new test
> output or modify the old test slightly to get it to produce the same
> case as before?

That's a judgement call, based on what you think the point of the test was.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Parallel worker error
Next
From: Pavan Deolasee
Date:
Subject: Re: [HACKERS] Parallel worker error