Re: pgsql: Move interrupt-handling code into subroutines. - Mailing list pgsql-committers

On Tue, Dec 17, 2019 at 1:43 PM Andrew Gierth
<andrew@tao11.riddles.org.uk> wrote:
> >>>>> "Robert" == Robert Haas <rhaas@postgresql.org> writes:
>
>  Robert> Move interrupt-handling code into subroutines.
>
> This is eliciting compiler warnings from gcc, which apparently doesn't
> count "static void foo();" as being a prototype (quite reasonably, since
> it's not).
>
> Needs this fix (in autovacuum.c and checkpointer.c):
>
> -static void AutoVacLauncherShutdown() pg_attribute_noreturn();
> +static void AutoVacLauncherShutdown(void) pg_attribute_noreturn();
>
> -static void HandleCheckpointerInterrupts();
> +static void HandleCheckpointerInterrupts(void);

Sorry about that. Fix pushed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company