Re: pgsql: Move interrupt-handling code into subroutines. - Mailing list pgsql-committers

From Andrew Gierth
Subject Re: pgsql: Move interrupt-handling code into subroutines.
Date
Msg-id 8736diaj98.fsf@news-spur.riddles.org.uk
Whole thread Raw
In response to pgsql: Move interrupt-handling code into subroutines.  (Robert Haas <rhaas@postgresql.org>)
Responses Re: pgsql: Move interrupt-handling code into subroutines.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
>>>>> "Robert" == Robert Haas <rhaas@postgresql.org> writes:

 Robert> Move interrupt-handling code into subroutines.

This is eliciting compiler warnings from gcc, which apparently doesn't
count "static void foo();" as being a prototype (quite reasonably, since
it's not).

Needs this fix (in autovacuum.c and checkpointer.c):

-static void AutoVacLauncherShutdown() pg_attribute_noreturn();
+static void AutoVacLauncherShutdown(void) pg_attribute_noreturn();

-static void HandleCheckpointerInterrupts();
+static void HandleCheckpointerInterrupts(void);

-- 
Andrew (irc:RhodiumToad)



pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Partially deduplicate interrupt handling for background processe
Next
From: Robert Haas
Date:
Subject: pgsql: Add missing "void" to prototypes.