Re: making EXPLAIN extensible - Mailing list pgsql-hackers

From Robert Haas
Subject Re: making EXPLAIN extensible
Date
Msg-id CA+Tgmob_cLoLdTnydXFNuR5ns_WWMDQSk5-ZM9kdoL6=+BXpQA@mail.gmail.com
Whole thread Raw
In response to Re: making EXPLAIN extensible  (Andrei Lepikhov <lepihov@gmail.com>)
Responses Re: making EXPLAIN extensible
List pgsql-hackers
On Sat, May 3, 2025 at 2:44 PM Andrei Lepikhov <lepihov@gmail.com> wrote:
> I have one additional proposal.
>
> I currently use this interface and have noticed that the parameter
> `option_name` in the RegisterExtensionExplainOption routine is
> case-sensitive. Since SQL treats our extended options as
> case-insensitive, it would be beneficial to either add a comment
> clarifying this behavior or forcedly convert incoming text constant to
> lowercase.

I don't think this is really true. It's just standard identifier
handling. You can have options with upper-case names if you quote
them.

robert.haas=# explain (verbose) select 1;
                QUERY PLAN
------------------------------------------
 Result  (cost=0.00..0.01 rows=1 width=4)
   Output: 1
(2 rows)

robert.haas=# explain (VERBOSE) select 1;
                QUERY PLAN
------------------------------------------
 Result  (cost=0.00..0.01 rows=1 width=4)
   Output: 1
(2 rows)

robert.haas=# explain ("verbose") select 1;
                QUERY PLAN
------------------------------------------
 Result  (cost=0.00..0.01 rows=1 width=4)
   Output: 1
(2 rows)

robert.haas=# explain ("VERBOSE") select 1;
ERROR:  unrecognized EXPLAIN option "VERBOSE"
LINE 1: explain ("VERBOSE") select 1;
                 ^

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Reduce "Var IS [NOT] NULL" quals during constant folding
Next
From: Robert Haas
Date:
Subject: Re: Statistics Import and Export