On 28/3/2025 14:09, Robert Haas wrote:
> On Thu, Mar 27, 2025 at 5:34 PM Andrei Lepikhov <lepihov@gmail.com> wrote:
>> I’m afraid to sound like a bore, but I think pg_overexplain should
>> include a call into the hook call chain (see attachment). Who knows,
>> maybe this extension will be used someday in production?
>
> Oh, bother, that was a silly mistake on my part. Thanks, committed.
I have one additional proposal.
I currently use this interface and have noticed that the parameter
`option_name` in the RegisterExtensionExplainOption routine is
case-sensitive. Since SQL treats our extended options as
case-insensitive, it would be beneficial to either add a comment
clarifying this behavior or forcedly convert incoming text constant to
lowercase.
--
regards, Andrei Lepikhov