Re: run pgindent on a regular basis / scripted manner - Mailing list pgsql-hackers

From Robert Haas
Subject Re: run pgindent on a regular basis / scripted manner
Date
Msg-id CA+TgmobWXtSciC6hahE0J5w01D6Z3LPv9ctb5Ty_ory4m-NiXQ@mail.gmail.com
Whole thread Raw
In response to Re: run pgindent on a regular basis / scripted manner  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
On Wed, Oct 18, 2023 at 3:21 AM Peter Eisentraut <peter@eisentraut.org> wrote:
> On 18.10.23 06:40, David Rowley wrote:
> > I agree that it's not nice to add yet another way of breaking the
> > buildfarm and even more so when the committer did make check-world
> > before committing. We have --enable-tap-tests, we could have
> > --enable-indent-checks and have pgindent check the code is correctly
> > indented during make check-world. Then just not have
> > --enable-indent-checks in CI.
>
> This approach seems like a good improvement, even independent of
> everything else we might do about this.  Making it easier to use and
> less likely to be forgotten.  Also, this way, non-committer contributors
> can opt-in, if they want to earn bonus points.

Yeah. I'm not going to push anything that doesn't pass make
check-world, so this is appealing in that something that I'm already
doing would (or could be configured to) catch this problem also.

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Query execution in Perl TAP tests needs work
Next
From: Robert Haas
Date:
Subject: Re: New WAL record to detect the checkpoint redo location