Re: run pgindent on a regular basis / scripted manner - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: run pgindent on a regular basis / scripted manner
Date
Msg-id a4ede79d-5503-425c-851d-5bf6487aaec9@eisentraut.org
Whole thread Raw
In response to Re: run pgindent on a regular basis / scripted manner  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: run pgindent on a regular basis / scripted manner
List pgsql-hackers
On 18.10.23 06:40, David Rowley wrote:
> I agree that it's not nice to add yet another way of breaking the 
> buildfarm and even more so when the committer did make check-world 
> before committing. We have --enable-tap-tests, we could have 
> --enable-indent-checks and have pgindent check the code is correctly 
> indented during make check-world. Then just not have 
> --enable-indent-checks in CI.

This approach seems like a good improvement, even independent of 
everything else we might do about this.  Making it easier to use and 
less likely to be forgotten.  Also, this way, non-committer contributors 
can opt-in, if they want to earn bonus points.




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Rename backup_label to recovery_control
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: Fix one hint message in 002_pg_upgrade.pl