Re: VACUUM fails to parse 0 and 1 as boolean value - Mailing list pgsql-hackers

From Robert Haas
Subject Re: VACUUM fails to parse 0 and 1 as boolean value
Date
Msg-id CA+TgmobK1ngid9Pxs7g8RFQDH+O1X4yyL+vMQtaV7i6m-Xn0rw@mail.gmail.com
Whole thread Raw
In response to Re: VACUUM fails to parse 0 and 1 as boolean value  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: VACUUM fails to parse 0 and 1 as boolean value
Re: VACUUM fails to parse 0 and 1 as boolean value
List pgsql-hackers
On Thu, May 16, 2019 at 2:56 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> Yes. Thanks for the comment!
> Attached is the updated version of the patch.
> It adds such common rule.

I'm not sure how much value it really has to define
opt_boolean_or_string_or_numeric.  It saves 1 line of code in each of
3 places, but costs 6 lines of code to have it.

Perhaps we could try to unify at a higher level.  Like can we merge
vac_analyze_option_list with explain_option_list?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: VACUUM fails to parse 0 and 1 as boolean value
Next
From: Peter Geoghegan
Date:
Subject: Re: VACUUM can finish an interrupted nbtree page split -- is that okay?