Postgres Pro
Downloads
Home   >   mailing lists

Re: Obsolete use of volatile in walsender.c, walreceiver.c, walreceiverfuncs.c? - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Obsolete use of volatile in walsender.c, walreceiver.c, walreceiverfuncs.c?
Date
Msg-id CA+Tgmob1k7rBTu=pdXt5-NM23cRakzkSH2RNES807NtzS0pWdQ@mail.gmail.com
Whole thread Raw
In response to Re: Obsolete use of volatile in walsender.c, walreceiver.c, walreceiverfuncs.c?  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Obsolete use of volatile in walsender.c, walreceiver.c, walreceiverfuncs.c?  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Tree view 
On Thu, Oct 1, 2015 at 11:01 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
>> Right, see attached.
>
> It seems to me that we could as well simplify checkpoint.c and
> logical.c. In those files volatile casts are used as well to protect
> from reordering for spinlock operations. See for example 0002 on top
> of 0001 that is Thomas' patch.

These patches look good to me, so I have committed them.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: bugs and bug tracking
Next
From: Robert Haas
Date:
Subject: Re: More work on SortSupport for text - strcoll() and strxfrm() caching