Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] binary heap implementation - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [PATCH] binary heap implementation
Date
Msg-id CA+Tgmoag3ymYyX1XCTbwuKS_NSavZnhwijwosTy_bmeZ0uid2Q@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] binary heap implementation  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Thu, Nov 15, 2012 at 10:21 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
>> Other than the coding style issues, I think this looks fine.  If you
>> can fix that up, I believe I could go ahead and commit this, unless
>> anyone else objects.
>
> Does this include the changes in nodeMergeappend.c?

I think so.  I was going to double-check the performance before
committing, but it doesn't look like there should be a problem.
Coding style changes appear needed in that file as well, however.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: tuplesort memory usage: grow_memtuples
Next
From: Andres Freund
Date:
Subject: Re: [PATCH] binary heap implementation