Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] binary heap implementation - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] binary heap implementation
Date
Msg-id 20121115162253.GA2736@awork2.anarazel.de
Whole thread Raw
In response to [PATCH] binary heap implementation  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
Responses Re: [PATCH] binary heap implementation  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
On 2012-11-14 18:41:12 +0530, Abhijit Menon-Sen wrote:
> There are two or three places in the Postgres source that implement heap
> sort (e.g. tuplesort.c, nodeMergeAppend.c), and it's also needed by the
> BDR code. It seemed reasonable to factor out the functionality.

pg_dump also contains a binary heap implementation if memory serves
right which makes me wonder whether we should try binaryheap.[ch]
backend clean... It currently uses palloc/pfree.

Too bad we don't have a memory allocation routine which easily works in
the backend and frontend... palloc references MemoryContextAlloc and
CurrentMemoryContext so thats not that easy to emulate.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [PATCH] binary heap implementation
Next
From: Alvaro Herrera
Date:
Subject: Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader