Re: Registering LWTRANCHE_PARALLEL_HASH_JOIN - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Registering LWTRANCHE_PARALLEL_HASH_JOIN
Date
Msg-id CA+Tgmoa_VUd3yWfHt7e-Kqpp4DCNhSgURcwtrU4L60_ns=+2fA@mail.gmail.com
Whole thread Raw
In response to Registering LWTRANCHE_PARALLEL_HASH_JOIN  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: Registering LWTRANCHE_PARALLEL_HASH_JOIN
List pgsql-hackers
On Sat, Feb 10, 2018 at 6:07 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> I forgot to register a display name for LWTRANCHE_PARALLEL_HASH_JOIN,
> the tranche ID used by the LWLock that Parallel Hash uses when handing
> out chunks of memory.  Please see attached.

I think that you need to insert some weasel words into the
documentation for this, because I don't think it's really accurate to
say that it's only used when trying to acquire a new chunk of memory.

Or maybe I'm wrong and it's altogether accurate ... but
ExecParallelHashMergeCounters doesn't look like an allocation to me,
and ExecParallelHashTuplePrealloc doesn't really look like an
allocation either.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Sigh, I broke crake again
Next
From: Tom Lane
Date:
Subject: Re: Let's remove DSM_INPL_NONE.