Re: Let's remove DSM_INPL_NONE. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Let's remove DSM_INPL_NONE.
Date
Msg-id 15255.1519760507@sss.pgh.pa.us
Whole thread Raw
In response to Re: Let's remove DSM_INPL_NONE.  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Let's remove DSM_INPL_NONE.  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Feb 15, 2018 at 1:00 PM, Andres Freund <andres@anarazel.de> wrote:
>> Hm, I'm not quite convinced by this. Seems to make testing a bunch of
>> codepaths harder.  I think it's fine to say that pg doesn't work
>> correctly with them disabled though.

> I'm not sure I understand this.  Do you mean we should just add a
> disclaimer to the documentation?

What I didn't understand about it was what kind of testing this'd make
harder.  If we desupport dynamic_shared_memory_type=none, there aren't
any code paths that need to cope with the case, and we should just
remove any code that thereby becomes unreachable.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Registering LWTRANCHE_PARALLEL_HASH_JOIN
Next
From: Robert Haas
Date:
Subject: Re: Wait event names mismatch: oldserxid