Re: patch for a locale-specific bug in regression tests (REL9_1_STABLE) - Mailing list pgsql-hackers

From Robert Haas
Subject Re: patch for a locale-specific bug in regression tests (REL9_1_STABLE)
Date
Msg-id CA+TgmoaRcf7m8Nm+26PM9+BuuZQq9vVEWbgtbHow+e2BHHFOkg@mail.gmail.com
Whole thread Raw
In response to patch for a locale-specific bug in regression tests (REL9_1_STABLE)  (Tomas Vondra <tv@fuzzy.cz>)
Responses Re: patch for a locale-specific bug in regression tests (REL9_1_STABLE)
List pgsql-hackers
On Tue, Mar 6, 2012 at 1:59 PM, Tomas Vondra <tv@fuzzy.cz> wrote:
> I've noticed a locale-specific bug in regression tests, I discovered
> thanks to the new "magpie" buildfarm member (testing "cs_CZ" locale).
> The problem is in "foreign_data" where the output is sorted by a column,
> and "cs_CZ" behaves differently from "C" and "en_US".
>
> More precisely, in "C" it's true that ('s4' < 'sc') but that's not true
> in cs_CZ (and supposedly some other locales).
>
> I've fixed this by replacing 'sc' with 't0' which seems to fix the
> ordering (and should work with other locales too). See the patch attached.

This was fixed on master in commit
3e9a2672d25aed15ae6b4a09decbd8927d069868, but that picked the name s0
rather than t0.  I suggest we make the same naming decision in the
back-branch to avoid future confusion...

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Marko Kreen
Date:
Subject: Re: [9.2] Confusion over CacheRegisterSyscacheCallback
Next
From: Tom Lane
Date:
Subject: Re: poll: CHECK TRIGGER?