Re: patch for a locale-specific bug in regression tests (REL9_1_STABLE) - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: patch for a locale-specific bug in regression tests (REL9_1_STABLE)
Date
Msg-id 4F57C049.3070908@fuzzy.cz
Whole thread Raw
In response to Re: patch for a locale-specific bug in regression tests (REL9_1_STABLE)  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: patch for a locale-specific bug in regression tests (REL9_1_STABLE)  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 7.3.2012 17:56, Robert Haas wrote:
> On Tue, Mar 6, 2012 at 1:59 PM, Tomas Vondra <tv@fuzzy.cz> wrote:
>> I've noticed a locale-specific bug in regression tests, I discovered
>> thanks to the new "magpie" buildfarm member (testing "cs_CZ" locale).
>> The problem is in "foreign_data" where the output is sorted by a column,
>> and "cs_CZ" behaves differently from "C" and "en_US".
>>
>> More precisely, in "C" it's true that ('s4' < 'sc') but that's not true
>> in cs_CZ (and supposedly some other locales).
>>
>> I've fixed this by replacing 'sc' with 't0' which seems to fix the
>> ordering (and should work with other locales too). See the patch attached.
> 
> This was fixed on master in commit
> 3e9a2672d25aed15ae6b4a09decbd8927d069868, but that picked the name s0
> rather than t0.  I suggest we make the same naming decision in the
> back-branch to avoid future confusion...

Yes, that's a better solution - I haven't noticed that commit. Should I
prepare a modified patch or is it possible to apply the fix from master
to this branch?

Tomas



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: poll: CHECK TRIGGER?
Next
From: Simon Riggs
Date:
Subject: Re: Checksums, state of play